-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JointControllerStateArray for group controllers #50
base: kinetic-devel
Are you sure you want to change the base?
Conversation
Could you elaborate please? |
Yes. |
This sounds very reasonable. Do you have a Pull Request on |
I am using PR2 but PR2 has its pr2_controllers. Therefore I only gave two pull requests for PR2. In this pull [request], I also built a new ros message (pr2_controllers_msgs/msg/JointControllerStateArray.msg). I have verified that this JointGroupVelocityController works well on PR2. Please see this video https://www.youtube.com/watch?v=rAj2IWl2ezs. I haven't tested JointGroupVelocityController on other robots. I am thinking to write a JointGroupEffortController interface for Shadow hand. |
@@ -0,0 +1,2 @@ | |||
Header header | |||
JointControllerState[] controllestate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Smilels The identifier looks like a typo. I would expect controller_state
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you. I have updated the variable name to controller_state.
No description provided.