From 772d8ad8b9c704a11a4cdce149e22d1a1fb04b56 Mon Sep 17 00:00:00 2001 From: Chris Rorden Date: Sun, 19 Mar 2023 08:09:59 -0400 Subject: [PATCH 1/2] Update issue templates Use `make` to compile development branch --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index a69ea02e..dd0a5a47 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -42,6 +42,6 @@ Please try the following steps to resolve your issue: ``` git clone --branch development https://github.com/rordenlab/dcm2niix.git cd dcm2niix/console -g++ -I. main_console.cpp nii_foreign.cpp nii_dicom.cpp jpg_0XC3.cpp ujpeg.cpp nifti1_io_core.cpp nii_ortho.cpp nii_dicom_batch.cpp -o dcm2niix -DmyDisableOpenJPEG +make ./dcm2niix .... ``` From 70007b68471af2e00b19967085200bbcf84715fa Mon Sep 17 00:00:00 2001 From: Tom Hampshire Date: Mon, 22 Apr 2024 07:57:31 +0100 Subject: [PATCH 2/2] Console script return status code (https://github.com/rordenlab/dcm2niix/issues/811) --- dcm2niix/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dcm2niix/__init__.py b/dcm2niix/__init__.py index 42b26c2d..91b1cb1c 100644 --- a/dcm2niix/__init__.py +++ b/dcm2niix/__init__.py @@ -24,10 +24,10 @@ def main(args=None, **run_kwargs): Arguments: args: defaults to `sys.argv[1:]`. **run_kwargs: passed to `subprocess.run`. - Returns: `subprocess.CompletedProcess` instance. + Returns: `int` exit code from dcm2niix execution. """ if args is None: import sys args = sys.argv[1:] from subprocess import run - return run([bin] + args, **run_kwargs) + return run([bin] + args, **run_kwargs).returncode