Warning pop up does not display when adding selected code with no code

[elinw]

When in the application if you click the add selected code button but there is no code in the field, the application crashes. @laderast Any thoughts? Maybe we could test for an empty field and return or else make the button inactive if there is no code.

[laderast]

I can add a validate for the button. In Japan right now, but I can add when I get home. Ted

…

On Nov 18, 2018, at 9:00 AM, elinw ***@***.***> wrote: When in the application if you click the add selected code button but there is no code in the field, the application crashes. @laderast Any thoughts? Maybe we could test for an empty field and return or else make the button inactive if there is no code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[elinw]

Great! Thanks.

…

On Nov 17, 2018, at 7:12 PM, Ted Laderas ***@***.***> wrote: I can add a validate for the button. In Japan right now, but I can add when I get home. Ted > On Nov 18, 2018, at 9:00 AM, elinw ***@***.***> wrote: > > When in the application if you click the add selected code button but there is no code in the field, the application crashes. @laderast Any thoughts? Maybe we could test for an empty field and return or else make the button inactive if there is no code. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#106 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuEfbxWQ5NeudxnWI6Oi5TMoGni5vqZks5uwKXugaJpZM4Yns_E>.

[laderast]

Created a pull request with the validate statement. it doesn't crash but for some reason the modal with the message isn't coming up if they don't have codes. I will continue to investigate.

[elinw]

Thanks, did you think about this any more? I wonder if we should close this as resolved and then create a new issue for the message not appearing. What do you think?