Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #291

Open
stitam opened this issue Sep 17, 2020 · 4 comments
Open

Increase test coverage #291

stitam opened this issue Sep 17, 2020 · 4 comments
Assignees

Comments

@stitam
Copy link
Contributor

stitam commented Sep 17, 2020

webchem's test coverage has fallen lately. The rOpenSci policy is 75% so let's bring it up to at least 75%.

https://devguide.ropensci.org/building.html#testing

@stitam stitam changed the title Increase test coverage above 75% Increase test coverage Sep 17, 2020
@Aariq
Copy link
Collaborator

Aariq commented Sep 18, 2020

What is the coverage when tests are run locally (i.e. ChemSpider is not skipped)? Might not be an issue, or might be a (somewhat) easy fix by adding a ChemSpider API token as a GitHub secret, then un-skipping those tests on CI.

@stitam
Copy link
Contributor Author

stitam commented Sep 21, 2020

I might ask for some help there, if I run covr::package_coverage() from the dev directory, I get 0% for everything, I am clearly missing something. On the other hand, ChemSpider is skipped because of the missing token and Flavornet seems to be down.

@Aariq
Copy link
Collaborator

Aariq commented Sep 21, 2020

I can give it a try later this week.

@Aariq Aariq assigned Aariq and unassigned Aariq Sep 21, 2020
@Aariq
Copy link
Collaborator

Aariq commented Sep 23, 2020

Local test coverage (with chemspider) is ~ 80%. But utils.R has lowest coverage, so boosting is probably a better idea than having chemspider tests run on CI.

@stitam stitam self-assigned this Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants