Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use explicit anchors #657

Open
eliocamp opened this issue Apr 21, 2023 · 7 comments
Open

Always use explicit anchors #657

eliocamp opened this issue Apr 21, 2023 · 7 comments
Assignees

Comments

@eliocamp
Copy link
Contributor

In reviewing the Spanish translation I've found this instance of a section without explicit anchor. An earlier section links to this one using the implicit anchor created by rmarkdown/quarto, but the link broke in the Spanish version because the name of the implicit anchor is now different.

## Editors and reviewers

Before sending a PR to address this particular case, perhaps it might be better to do a holistic revision to add explicit anchors to every section in one single PR.

@mpadge
Copy link
Member

mpadge commented Apr 24, 2023

Even better would be a workflow file that ensured that every section and sub-section had an explicit anchor. That could be integrated as part of the general PR workflow. @maelle How about i write a script for that, let you know when that's done, and you can plug it in to the workflow?

@maelle
Copy link
Member

maelle commented May 2, 2023

Oh good catch @eliocamp!

@mpadge Yep but first I'll make a bigger PR ensuring current content has such explicit references.

For my own reference: https://quarto.org/docs/authoring/cross-references.html#sections

@maelle
Copy link
Member

maelle commented May 9, 2023

I've done some work on this, right now I have one (last?) blocker which is that titles à la Ajustar la fecha límite de la revisión {.unnumbered} {#tweak-review-due-date} don't work, even if I change the order of the curly braces thingies. The second one is rendered as is, not used.

@maelle
Copy link
Member

maelle commented May 9, 2023

@maelle
Copy link
Member

maelle commented May 9, 2023

this is only a problem for the bot cheatsheet. Maybe we don't need explicit cross-references for it, or maybe it wouldn't be horrible to have numbers there.

@maelle
Copy link
Member

maelle commented May 11, 2023

  1. Add explicit anchors
  2. Check existing internal links
  3. PR workflow

@maelle
Copy link
Member

maelle commented May 11, 2023

@mpadge note that I need to be working on a PR workflow anyway.
For each PR,

  • if change in a doc in a language,
  • transform to XML and translate the same node in the other languages.

this works if all languages have the same XML structure (header, paragraphs) -- which this work on anchors helped check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants