Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite for bibtex #46

Merged
merged 20 commits into from
Jan 13, 2022
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ revdep
^_pkgdown\.yml$
^docs$
^pkgdown$
^bibtex\.Rcheck$
^bibtex.*\.tar\.gz$
^bibtex.*\.tgz$
13 changes: 12 additions & 1 deletion .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ jobs:
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel/1'}
- {os: ubuntu-latest, r: 'oldrel/2'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, we should upgrade to the latest action calls.

# Use 3.6 to trigger usage of RTools35
- {os: windows-latest, r: '3.6'}
# Use older ubuntu to maximise backward compatibility
- {os: ubuntu-18.04, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-18.04, r: 'release'}
- {os: ubuntu-18.04, r: 'oldrel-1'}
- {os: ubuntu-18.04, r: 'oldrel-2'}


env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -41,7 +50,9 @@ jobs:

- uses: r-lib/actions/setup-r-dependencies@v1
with:
extra-packages: rcmdcheck
extra-packages: |
rcmdcheck
devtools

- name: Check
env:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ jobs:

- uses: r-lib/actions/setup-r-dependencies@v1
with:
extra-packages: covr
extra-packages: |
covr
devtools

- name: Test coverage
run: covr::codecov()
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ src/*.so
src/*.dll
bibtex.Rproj
docs
bibtex.Rcheck/
bibtex*.tar.gz
bibtex*.tgz
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ Depends:
Imports:
utils
Suggests:
testthat
testthat (>= 3.0.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as an author in the DESCRIPTION file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you

LazyLoad: yes
Encoding: UTF-8
RoxygenNote: 7.1.1
RoxygenNote: 7.1.2
Config/testthat/edition: 3
22 changes: 22 additions & 0 deletions inst/bib/multiline_string.bib
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
@String{inst-CS-U-MARYLAND = "Department of Computer Science,
University of Maryland"}


@TechReport{Golub:1976:RDLb,
author = "G. H. Golub and Virginia Klema and G. W. {Stewart
III}",
title = "Rank Degeneracy and Least Squares Problems",
type = "Report",
number = "TR-751",
institution = inst-CS-U-MARYLAND,
pages = "????",
month = "????",
year = "1976",
bibdate = "Thu May 29 16:12:45 2014",
bibsource = "http://www.math.utah.edu/pub/bibnet/authors/g/golub-gene-h.bib;
http://www.math.utah.edu/pub/bibnet/authors/s/stewart-gilbert-w.bib",
acknowledgement = ack-nhfb,
GWSnumber = "N6",
xxnote = "Check: is this the same as Golub:1976:RDLa? If so,
which report number is correct??",
}
10 changes: 10 additions & 0 deletions inst/bib/unable_recover_42.bib
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
@String{{BAZ = "Foo Bar Baz" }

@misc{murdoch:2009,
author = "Duncan Murdoch",
title = "Parsing Rd files",
year = 2009,
institution = BAZ,
url = "http://developer.r-project.org/parseRd.pdf"
}

15 changes: 15 additions & 0 deletions inst/bib/unbalanced_braces.bib
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
@misc{murdoch:2009,
author = "Duncan Murdoch",
title = "Parsing Rd files",
year = 2009,
url = "http://developer.r-project.org/parseRd.pdf"
}


@misc{murdoch:2010,
author = "Duncan Murdoch",
title = {"Parsing {Rd} files unbalanced",
year = 2010,
url = "http://developer.r-project.org/parseRd.pdf"
}

Loading