-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test suite for bibtex #46
Merged
Merged
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9a3dccd
Upgrade testing suite to testthat 3
dieghernan 0918cfd
Add testing for previous issues
dieghernan 4053f15
Add tests for standard bibtex entries
dieghernan db4e1a9
Update actions
dieghernan b99129b
Add testing for examples
dieghernan 22459a1
Add snapshots for examples read.bib This may fail on some platforms
dieghernan 9aebbc9
Skip on non windows
dieghernan f2772bb
Not test on R 3.4
dieghernan ef9c6b6
Add more tests
dieghernan 2325dfd
Try to increase coverage
dieghernan f56c65e
One more tests for do_read_bib
dieghernan 408cd89
Fix test for do_read_bib
dieghernan 73d0303
Revert actions
dieghernan c46a194
Add devtools for testing
dieghernan 143fdaf
Add more tests
dieghernan b2b1417
Add test for multiline string
dieghernan 9dc73c3
Add non standard field names
dieghernan 83cfe61
Add myself as author
dieghernan 24ed42c
Move issues to inst/bib files
dieghernan a98400a
Refactor tests for avoiding cluttering
dieghernan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,6 @@ revdep | |
^_pkgdown\.yml$ | ||
^docs$ | ||
^pkgdown$ | ||
^bibtex\.Rcheck$ | ||
^bibtex.*\.tar\.gz$ | ||
^bibtex.*\.tgz$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,6 @@ src/*.so | |
src/*.dll | ||
bibtex.Rproj | ||
docs | ||
bibtex.Rcheck/ | ||
bibtex*.tar.gz | ||
bibtex*.tgz |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,8 @@ Depends: | |
Imports: | ||
utils | ||
Suggests: | ||
testthat | ||
testthat (>= 3.0.0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add yourself as an author in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, thank you |
||
LazyLoad: yes | ||
Encoding: UTF-8 | ||
RoxygenNote: 7.1.1 | ||
RoxygenNote: 7.1.2 | ||
Config/testthat/edition: 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
@String{inst-CS-U-MARYLAND = "Department of Computer Science, | ||
University of Maryland"} | ||
|
||
|
||
@TechReport{Golub:1976:RDLb, | ||
author = "G. H. Golub and Virginia Klema and G. W. {Stewart | ||
III}", | ||
title = "Rank Degeneracy and Least Squares Problems", | ||
type = "Report", | ||
number = "TR-751", | ||
institution = inst-CS-U-MARYLAND, | ||
pages = "????", | ||
month = "????", | ||
year = "1976", | ||
bibdate = "Thu May 29 16:12:45 2014", | ||
bibsource = "http://www.math.utah.edu/pub/bibnet/authors/g/golub-gene-h.bib; | ||
http://www.math.utah.edu/pub/bibnet/authors/s/stewart-gilbert-w.bib", | ||
acknowledgement = ack-nhfb, | ||
GWSnumber = "N6", | ||
xxnote = "Check: is this the same as Golub:1976:RDLa? If so, | ||
which report number is correct??", | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
@String{{BAZ = "Foo Bar Baz" } | ||
|
||
@misc{murdoch:2009, | ||
author = "Duncan Murdoch", | ||
title = "Parsing Rd files", | ||
year = 2009, | ||
institution = BAZ, | ||
url = "http://developer.r-project.org/parseRd.pdf" | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
@misc{murdoch:2009, | ||
author = "Duncan Murdoch", | ||
title = "Parsing Rd files", | ||
year = 2009, | ||
url = "http://developer.r-project.org/parseRd.pdf" | ||
} | ||
|
||
|
||
@misc{murdoch:2010, | ||
author = "Duncan Murdoch", | ||
title = {"Parsing {Rd} files unbalanced", | ||
year = 2010, | ||
url = "http://developer.r-project.org/parseRd.pdf" | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self, we should upgrade to the latest action calls.