Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal size argument has no effect #6

Open
dovy opened this issue Jul 9, 2014 · 2 comments
Open

Modal size argument has no effect #6

dovy opened this issue Jul 9, 2014 · 2 comments
Assignees

Comments

@dovy
Copy link
Contributor

dovy commented Jul 9, 2014

According to: http://angular-ui.github.io/bootstrap/#/modal

There is a size argument that you should be able to add to the arguments of .open().

IE:

$modal.open({
      templateUrl: 'myModalContent.html',
      controller: ModalInstanceCtrl,
      size: 'lg',

Yet it has no effect. Are we not using the angular boostrap directive or are we overloading it before that added class can occur?

@DallanQ
Copy link
Member

DallanQ commented Jul 9, 2014

We're using a branch of an older version of angular-ui that supports html in popovers, but doesn't support the size argument in the modal. I expect/hope that a new release of angular-ui will contain the pull request implemented in the branch that we're using so we get both.

@dovy
Copy link
Contributor Author

dovy commented Jul 9, 2014

Ahh. That makes a ton more sense. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants