Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Trellias alias should add snippet to site/wp-cli.yml or an alternative wp-cli.yml (or wp-cli.local.yml) config. #408

Open
chrillep opened this issue Aug 8, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@chrillep
Copy link

chrillep commented Aug 8, 2023

Summary

it would be nice if the alias command automaticly added the

_:
  inherit: wp-cli.trellis-alias.yml

snippet to site/wp-cli.yml or an alternative wp-cli.yml (or wp-cli.local.yml) config. ❤️

AC:

alias command

  • should add snippet to config file
  • should not add if snippet exists

Additional context

No response

@chrillep chrillep added the enhancement New feature or request label Aug 8, 2023
@chrillep chrillep changed the title Trellias alias should add snippet to site/wp-cli.yml or an alternative wp-cli.yml (or wp-cli.local.yml) config. 💡 Trellias alias should add snippet to site/wp-cli.yml or an alternative wp-cli.yml (or wp-cli.local.yml) config. Aug 8, 2023
@chrillep chrillep changed the title 💡 Trellias alias should add snippet to site/wp-cli.yml or an alternative wp-cli.yml (or wp-cli.local.yml) config. 💡 Trellias alias should add snippet to site/wp-cli.yml Aug 8, 2023
@chrillep chrillep changed the title 💡 Trellias alias should add snippet to site/wp-cli.yml 💡 Trellias alias should add snippet to site/wp-cli.yml or an alternative wp-cli.yml (or wp-cli.local.yml) config. Aug 8, 2023
@swalkinshaw
Copy link
Member

@tangrufus had good thoughts on this a while ago: #246 (comment)

Personally I think we could probably implement the search & replace between some comment blocks without too much issue but as is this is much less risky.

@chrillep
Copy link
Author

chrillep commented Aug 9, 2023

i agree seems like a no brainer 🧠 .
I would almost go so far as to have the snippet and the alias file added by default to roots/trellis

And the alias command to just update the content?

The comments would then help in migration to this opt out default.
I mean why not have this by default, its such a quality of life thing.

@chrillep
Copy link
Author

chrillep commented Aug 9, 2023

BTW the only reason i didnt use trellis alias before, was cause i didnt know about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants