Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable IDs killed image reloading after animation #86

Open
Mauker1 opened this issue Oct 4, 2018 · 2 comments
Open

Stable IDs killed image reloading after animation #86

Mauker1 opened this issue Oct 4, 2018 · 2 comments

Comments

@Mauker1
Copy link
Collaborator

Mauker1 commented Oct 4, 2018

Expected Behavior

Once an user posts an image on the chat, it's supposed to show the thumbnail, and after the image is tapped, it's supposed to show the large version of the image.

Current Behavior

After the commit df3678a we started using stable ids on the RecyclerView, but as a side effect, the chat message won't reload after the user taps it, showing a low quality image.

Possible Solution

Perhaps we could set a listener to the imageview, once the animation is finished we could force an image reload.

Steps to Reproduce (for bugs)

  1. Open chat
  2. Locate or post any image
  3. Tap the image

Your Environment

  • Version used: 54b1cf7
  • Android version: 5.1 and 8.0
@raghunandankavi2010
Copy link
Contributor

raghunandankavi2010 commented Oct 5, 2018

dam!. i din't test this scenario. nice catch!. one question the images can be gif also right?

@Mauker1
Copy link
Collaborator Author

Mauker1 commented Oct 5, 2018

Yes, it can also be a GIF, but I don't remember if we had gif support before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants