Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for quotes #48

Open
TristanWiley opened this issue Nov 7, 2017 · 7 comments
Open

Add support for quotes #48

TristanWiley opened this issue Nov 7, 2017 · 7 comments

Comments

@TristanWiley
Copy link
Collaborator

I want to get this in for v1.0

@TristanWiley TristanWiley added this to the Version 1.0 milestone Nov 7, 2017
@raghunandankavi2010
Copy link
Contributor

raghunandankavi2010 commented Oct 3, 2018

I would like to discuss on this further. Suggestion welcome. Do we need custom spans and draw the " " at the start and end?

@Mauker1
Copy link
Collaborator

Mauker1 commented Oct 4, 2018

Not necessarily with the quotation marks. On the web chat, once you add a > It'll draw a vertical line at the beginning of the message, and add some padding to the text. We could try to do something similar on the app.

Example:
Quotes

@raghunandankavi2010
Copy link
Contributor

This can be done with QuoteSpan https://developer.android.com/reference/android/text/style/QuoteSpan . So if message starts with > it's quoted message?

@TimCastelijns
Copy link
Collaborator

Yes. QuoteSpan looks good, go for it. Indeed a quoted message has the format of > message

@raghunandankavi2010
Copy link
Contributor

raghunandankavi2010 commented Oct 14, 2018

Another case where message does not start with > message
quote

QuoteSpan works for other cases.

raghunandankavi2010 added a commit to raghunandankavi2010/ChatSE that referenced this issue Oct 14, 2018
Add QutoeSpan for text that starts with > Message
raghunandankavi2010 added a commit to raghunandankavi2010/ChatSE that referenced this issue Oct 14, 2018
Add QutoeSpan for text that starts with > Message
@TimCastelijns
Copy link
Collaborator

That's not a quote, that's a permalink

@raghunandankavi2010
Copy link
Contributor

ok. the link shows as a green square block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants