Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Genesis] Build genesis per chain ID #716

Closed
jolestar opened this issue Aug 29, 2023 · 4 comments · Fixed by #719
Closed

[Genesis] Build genesis per chain ID #716

jolestar opened this issue Aug 29, 2023 · 4 comments · Fixed by #719
Labels
enhancement New feature or request
Milestone

Comments

@jolestar
Copy link
Contributor

  1. Build genesis for every chain ID.
  2. Should we remove the genesis file from the source repo to avoid PR conflict?
  3. Maybe we need to include the move binary module in the rust binary for the Genesis package building.

#604

@jolestar jolestar added the enhancement New feature or request label Aug 29, 2023
@jolestar jolestar added this to the Rooch v0.2 milestone Aug 29, 2023
@pause125
Copy link
Collaborator

What's the benefits of adding genesis file in commits?
I prefer removing it.

@jolestar
Copy link
Contributor Author

We need to add the move bytecode files to the rooch binary.

I added move stdlib binary in commits and removed the genesis file in #719 .

I also plan to remove the stdlib binary from commits but include it in the rust binary #714

@baichuan3
Copy link
Collaborator

We need to add the move bytecode files to the rooch binary.

I added move stdlib binary in commits and removed the genesis file in #719 .

I also plan to remove the stdlib binary from commits but include it in the rust binary #714

If genesis file included in the rust library, Will conflicts due to contract changes be completely avoided?

@jolestar
Copy link
Contributor Author

The genesis, stdlib, and error_code_map binary files easily cause file conflicts. I try to remove them from the source code repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants