Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: tracing certain slow tx execution #3057

Closed
popcnt1 opened this issue Dec 16, 2024 · 3 comments
Closed

proposal: tracing certain slow tx execution #3057

popcnt1 opened this issue Dec 16, 2024 · 3 comments
Assignees
Labels
proposal New external API or other notable changes
Milestone

Comments

@popcnt1
Copy link
Collaborator

popcnt1 commented Dec 16, 2024

Proposal Details

mainnet: 198 & 984 take 10-30min to finish execution

hang nothing has been done, no disk io, but high secp overhead

approach:

  1. add cmd rooch db get-changeset-by-order
  2. re-execute DA chunks and checkout a branch which will save changeset when rooch da exec
  3. searchi changeset by 1

#3031

@popcnt1 popcnt1 added the proposal New external API or other notable changes label Dec 16, 2024
@popcnt1 popcnt1 added this to the Rooch v0.9 milestone Dec 16, 2024
@popcnt1 popcnt1 self-assigned this Dec 16, 2024
@popcnt1
Copy link
Collaborator Author

popcnt1 commented Dec 16, 2024

may caused by bad logic of rooch da exec, because we have to wait long time to load segments from disk, pack into chunk(need verify signature in this process), that's why we see so many secp releated functions.

I've update codes about it, using binary search to find good begin chunk, saving lots of time to reduce the init process.

But I remember tx_order 198 stall is in the middle of the whole execution process, may caused by too big chunk verification signature? and 198 is in this middle of first chunk, there is no reason wait for verification of signature.

Anyway, wait to reproduce it by re-execute from tx_order 1 and save changeset.

@popcnt1
Copy link
Collaborator Author

popcnt1 commented Dec 16, 2024

not in hurry, move it TBD (no more stall transcation found)

@popcnt1 popcnt1 modified the milestones: Rooch v0.9, TBD Dec 16, 2024
@popcnt1
Copy link
Collaborator Author

popcnt1 commented Dec 19, 2024

after updates da exec logic, no slow tx execution found. To be more precise, the two cases here, 198 and 984, both executed in milliseconds.

@popcnt1 popcnt1 closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Done in Rooch Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal New external API or other notable changes
Projects
Status: Done
Development

No branches or pull requests

1 participant