-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 7-bit methods public #6
Comments
Last time I checked this library has total feature parity with the 2 reader/writer classes found in .NET's BCL. The 7-bit methods are used for communicating string lengths and are not intended for consumer use. The reason for 7 bit encoding is so that the fewest number of bytes can be used to represent the length of the string being transmitted. The remaining bit is dedicated to signalling whether additional bytes should be codec'd for the string length. As for the Int64 variants, do you mean these? |
I mean |
That's news to me; I doubt they were public at the time, since the entire implementation is a copy-paste-edit. Submit a PR and I'll merge and deploy it. |
There are many more changes and optimizations in .NET 6 source code. I haven't studied older versions. |
Why are those methods reading and writing 7-bit encoded integers protected?
Also missing Int64 variants.
The text was updated successfully, but these errors were encountered: