From 2a9bcd682e9cb63253e7a8478be881e046fa43ef Mon Sep 17 00:00:00 2001
From: Hailong Cui <ihailong@amazon.com>
Date: Mon, 3 Jul 2023 16:50:31 +0800
Subject: [PATCH] remove runtime notification settings (#839)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
---
 .../filter/NotificationActionListener.kt      |   7 +-
 .../filter/NotificationActionListenerIT.kt    | 115 ++++++++++++------
 2 files changed, 82 insertions(+), 40 deletions(-)

diff --git a/src/main/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListener.kt b/src/main/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListener.kt
index cf44441fe..81411165c 100644
--- a/src/main/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListener.kt
+++ b/src/main/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListener.kt
@@ -235,9 +235,12 @@ class NotificationActionListener<Request : ActionRequest, Response : ActionRespo
                     }
                 }
             }
+        }
 
-            // remove one time configuration no matter it is enabled or not
-            removeOneTimePolicy(config)
+        // remove one time configuration
+        val runtimeConfig = lronConfigResponse.lronConfigResponses.firstOrNull() { it.lronConfig.taskId != null }
+        runtimeConfig?.let {
+            removeOneTimePolicy(it.lronConfig)
         }
     }
 
diff --git a/src/test/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListenerIT.kt b/src/test/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListenerIT.kt
index 838bb1d79..0f4b9f20c 100644
--- a/src/test/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListenerIT.kt
+++ b/src/test/kotlin/org/opensearch/indexmanagement/controlcenter/notification/filter/NotificationActionListenerIT.kt
@@ -13,6 +13,7 @@ import org.junit.After
 import org.junit.Assert
 import org.junit.Before
 import org.opensearch.action.admin.indices.open.OpenIndexAction
+import org.opensearch.client.Response
 import org.opensearch.client.ResponseException
 import org.opensearch.client.RestClient
 import org.opensearch.common.settings.Settings
@@ -198,25 +199,7 @@ class NotificationActionListenerIT : IndexManagementRestTestCase() {
 
     @Suppress("UNCHECKED_CAST")
     fun `test notify for reindex`() {
-        insertSampleData("source-index", 10)
-        createIndex("reindex-dest", Settings.EMPTY)
-
-        val response = client.makeRequest(
-            "POST", "_reindex?wait_for_completion=false",
-            StringEntity(
-                """
-                {
-                  "source": {
-                    "index": "source-index"
-                  },
-                  "dest": {
-                    "index": "reindex-dest"
-                  }
-                }
-                """.trimIndent(),
-                ContentType.APPLICATION_JSON
-            )
-        )
+        val response = performReindex()
 
         Assert.assertTrue(response.restStatus() == RestStatus.OK)
 
@@ -323,25 +306,7 @@ class NotificationActionListenerIT : IndexManagementRestTestCase() {
 
     @Suppress("UNCHECKED_CAST")
     fun `test notify for reindex with duplicate channel`() {
-        insertSampleData("source-index", 10)
-        createIndex("reindex-dest", Settings.EMPTY)
-
-        val response = client.makeRequest(
-            "POST", "_reindex?wait_for_completion=false",
-            StringEntity(
-                """
-                {
-                  "source": {
-                    "index": "source-index"
-                  },
-                  "dest": {
-                    "index": "reindex-dest"
-                  }
-                }
-                """.trimIndent(),
-                ContentType.APPLICATION_JSON
-            )
-        )
+        val response = performReindex()
 
         Assert.assertTrue(response.restStatus() == RestStatus.OK)
         val taskId = response.asMap()["task"] as String
@@ -448,4 +413,78 @@ class NotificationActionListenerIT : IndexManagementRestTestCase() {
             )
         }
     }
+
+    @Suppress("UNCHECKED_CAST")
+    fun `test runtime policy been removed when index operation finished`() {
+        val response = performReindex()
+
+        Assert.assertTrue(response.restStatus() == RestStatus.OK)
+        val taskId = response.asMap()["task"]
+        Assert.assertNotNull(taskId)
+
+        // put runtime policy only for failure
+        client.makeRequest(
+            "POST", "_plugins/_im/lron",
+            StringEntity(
+                """
+                    {
+                        "lron_config": {
+                            "task_id": "$taskId",
+                            "lron_condition": {
+                                "failure": true,
+                                "success": false
+                            },
+                            "channels": [
+                                {
+                                    "id": "$notificationConfId"
+                                }
+                            ]
+                        }
+                    }
+                """.trimIndent(),
+                ContentType.APPLICATION_JSON
+            )
+        )
+
+        waitFor(Instant.ofEpochSecond(60)) {
+            assertEquals(
+                "Notification index does not have a doc",
+                1,
+                (
+                    client.makeRequest("GET", "$notificationIndex/_search?q=msg:reindex")
+                        .asMap() as Map<String, Map<String, Map<String, Any>>>
+                    )["hits"]!!["total"]!!["value"]
+            )
+
+            try {
+                client.makeRequest("GET", "_plugins/_im/lron/LRON:$taskId")
+            } catch (e: ResponseException) {
+                // runtime policy been removed
+                Assert.assertTrue(e.response.restStatus() == RestStatus.NOT_FOUND)
+            }
+        }
+    }
+
+    private fun performReindex(): Response {
+        insertSampleData("source-index", 10)
+        createIndex("reindex-dest", Settings.EMPTY)
+
+        val response = client.makeRequest(
+            "POST", "_reindex?wait_for_completion=false",
+            StringEntity(
+                """
+                    {
+                      "source": {
+                        "index": "source-index"
+                      },
+                      "dest": {
+                        "index": "reindex-dest"
+                      }
+                    }
+                """.trimIndent(),
+                ContentType.APPLICATION_JSON
+            )
+        )
+        return response
+    }
 }