Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application of Filters is not idempotent #89

Open
benjaminleighton opened this issue Jul 22, 2024 · 1 comment
Open

Application of Filters is not idempotent #89

benjaminleighton opened this issue Jul 22, 2024 · 1 comment
Assignees

Comments

@benjaminleighton
Copy link
Collaborator

I'm fairly sure that applying a time filter on a elev2D but probably all data objects changes the held xarray Dataset object making reuse of that SCHISMDataBoundary for a different time not possible. I think this problem is prevalent across everything using Filter and DataGrid or DataBlob

@benjaminleighton
Copy link
Collaborator Author

benjaminleighton commented Jul 25, 2024

bug_filtering.zip

This appears to be due to non-idempotent behavious in filter and we've narrowed it down to self.filter.crop.update({self.coords.t: Slice(start=start, stop=end)}) in ocean_forcing.elev2D._filter_time. See attached notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants