Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch should define Hash method #11

Open
tzdybal opened this issue Sep 30, 2024 · 0 comments
Open

Batch should define Hash method #11

tzdybal opened this issue Sep 30, 2024 · 0 comments
Labels
enhancement New feature or request needs-triage

Comments

@tzdybal
Copy link
Member

tzdybal commented Sep 30, 2024

It is crucial that both the client and server side of go-sequencing API is using exactly the same method of hashing transactions from a Batch. To ensure this, Batch.Hash() method should be defined. Without this, lastBatchHash parameter is very fragile to any implementation changes..

In case of Go implementation, this method will be available for programmers. It will also serve as an example for implementations in other languages.

@tzdybal tzdybal added the enhancement New feature or request label Sep 30, 2024
@tzdybal tzdybal added this to Rollkit Sep 30, 2024
@tzdybal tzdybal changed the title Batch should define Hash method Batch should define Hash method Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage
Projects
Status: No status
Development

No branches or pull requests

1 participant