Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/554 poc ssg nextjs #602

Merged
merged 65 commits into from
Nov 4, 2024
Merged

Feat/554 poc ssg nextjs #602

merged 65 commits into from
Nov 4, 2024

Conversation

YulikK
Copy link
Collaborator

@YulikK YulikK commented Oct 10, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Migrating to Next.js framework

Transition issues:

  • Removing react-router, change navigation hooks
  • Importing images now gives an object as a result. Added src field to all image variable
  • Removed useSizeWindo hook
  • Removed useTitle hook, moving title setting logic to route files
  • Removed hooks for data request, I pass data directly from the route file.
  • Problem with naming folders by fsd. Renamed pages folder to views folder. Renamed app folder to core folder
  • Disable eslint rule for default export
  • Removed ScrollRestoration
  • Dayjs.isBetween same problem as when switching to remix, import changed a bit
  • Deleted all test files

Related Tickets & Documents

Screenshots, Recordings

Please replace this line with any relevant images for UI changes.

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

gif

@YulikK YulikK self-assigned this Oct 10, 2024
@YulikK YulikK added this to the πŸ’« Migration to SSG milestone Oct 10, 2024
@SpaNb4
Copy link
Collaborator

SpaNb4 commented Oct 10, 2024

Problems I've noticed so far:

image
image

  1. bluh
    image

.prettierrc Show resolved Hide resolved
.husky/pre-push Outdated Show resolved Hide resolved
dev-data/about.data.tsx Outdated Show resolved Hide resolved
dev-data/about.data.tsx Outdated Show resolved Hide resolved
dev-data/courseTitles.data.ts Outdated Show resolved Hide resolved
src/shared/ui/image/image.tsx Outdated Show resolved Hide resolved
src/views/aws-developer.tsx Outdated Show resolved Hide resolved
src/widgets/about-video/ui/about-video.tsx Outdated Show resolved Hide resolved
src/widgets/about/ui/about.tsx Outdated Show resolved Hide resolved
src/widgets/course-main/utils/get-course-status.ts Outdated Show resolved Hide resolved
dev-data/courseTitles.data.ts Outdated Show resolved Hide resolved
dev-data/courseTitles.data.ts Outdated Show resolved Hide resolved
dev-data/courseTitles.data.ts Outdated Show resolved Hide resolved
dev-data/required.data.ts Outdated Show resolved Hide resolved
dev-data/training-program.data.tsx Outdated Show resolved Hide resolved
src/widgets/study-path/ui/stage-card/stage-card.types.ts Outdated Show resolved Hide resolved
src/widgets/study-path/ui/study-path.tsx Outdated Show resolved Hide resolved
src/widgets/training-program/ui/training-program.tsx Outdated Show resolved Hide resolved
src/widgets/training-program/ui/training-program.tsx Outdated Show resolved Hide resolved
@MielomankA

This comment was marked as resolved.

@Quiddlee Quiddlee marked this pull request as ready for review October 26, 2024 10:01
@SpaNb4 SpaNb4 added preview and removed preview labels Nov 4, 2024
@apalchys apalchys added preview and removed preview labels Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Lighthouse Report:

  • Performance: 73 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@apalchys
Copy link
Member

apalchys commented Nov 4, 2024

@YulikK @Quiddlee I updated PR with the latest changes from the main and it fixed feature branch deployed. It doesn't work if any conflicts exist

@Quiddlee Quiddlee merged commit b66957f into main Nov 4, 2024
3 checks passed
@Quiddlee Quiddlee deleted the feat/554-poc-ssg-nextjs branch November 4, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants