Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollbarNotifier class is missing in Monolog handlers folder #249

Closed
jianzhong opened this issue Aug 8, 2017 · 4 comments
Closed

RollbarNotifier class is missing in Monolog handlers folder #249

jianzhong opened this issue Aug 8, 2017 · 4 comments
Assignees
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Milestone

Comments

@jianzhong
Copy link

jianzhong commented Aug 8, 2017

In monolog/src/Monolog/Handler/RollbarHandler.php, the class is trying to use a non-existing class 'RollbarNotifier' as the first parameter in the constructor. This causes PHP fatal error in my Symfony application. Our Rollbar upgrade failed due to this issue.

@ArturMoczulski ArturMoczulski self-assigned this Aug 11, 2017
@jianzhong
Copy link
Author

I've made a further investigation on the issue. The issue happened when I was trying to upgrade Rollbar from 0.18.2 to a later version by doing composer require ~1.1. The error was something like:

PHP Fatal error: Uncaught Error: Class 'RollbarNotifier' not found in ......

I noticed some changes in the autoload_psr4.php file under vendor\composer folder. The line

'Rollbar\' => array($vendorDir . '/rollbar/rollbar/src'),

becomes

'RollbarNotifier\' => array($vendorDir . '/rollbar/rollbar/src'),

If I changed RollbarNotifier to Rollbar, then I got another error in my Symfony application:

PHP Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "RollbarNotifier" from the global namespace.

@ArturMoczulski
Copy link
Contributor

ArturMoczulski commented Aug 16, 2017

This is ready for Monolog's team review in the following PR Seldaek/monolog#1042

As soon as the PR is merged to Monolog's master, simple composer update should resolve the issue. Until then I recommend using the changes included in the PR branch.

@rivkahstandig3636 rivkahstandig3636 added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Dec 27, 2017
@ArturMoczulski ArturMoczulski added this to the v1.4.1 milestone Feb 6, 2018
@ArturMoczulski
Copy link
Contributor

It doesn't look like our PR for Seldaek:monolog is going to get merged anytime soon. In meantime, I included Rollbar\Monolog\Handler\RollbarHandler in our repo. Please, use rollbar/rollbar-php:master or wait until tag v1.4.1.

@letaniaferreira
Copy link

letaniaferreira commented Dec 12, 2019

related rollbar/rollbar-php-laravel#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

No branches or pull requests

4 participants