From 561bee727e48de0294888114ca257cbfa1504d73 Mon Sep 17 00:00:00 2001 From: Joshua Bixler Date: Mon, 10 Feb 2020 10:04:51 -0600 Subject: [PATCH 1/2] Update HttpPlugin to return bool to match Magento --- Plugin/HttpPlugin.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Plugin/HttpPlugin.php b/Plugin/HttpPlugin.php index 0072c32..7a80a64 100755 --- a/Plugin/HttpPlugin.php +++ b/Plugin/HttpPlugin.php @@ -4,10 +4,10 @@ class HttpPlugin { - public function aroundCatchException($subject, $callable, $bootstrap, $exception) + public function aroundCatchException($subject, $callable, $bootstrap, $exception): bool { $callable($bootstrap, $exception); - \Rollbar\Rollbar::error($exception); + return \Rollbar\Rollbar::error($exception)->wasSuccessful(); } -} \ No newline at end of file +} From df42f36f9375ba3b0e20614e731fd9efce8dbb05 Mon Sep 17 00:00:00 2001 From: Joshua Bixler Date: Wed, 23 Aug 2023 14:53:41 -0500 Subject: [PATCH 2/2] Update HttpPlugin.php --- Plugin/HttpPlugin.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Plugin/HttpPlugin.php b/Plugin/HttpPlugin.php index 7a80a64..06ad348 100755 --- a/Plugin/HttpPlugin.php +++ b/Plugin/HttpPlugin.php @@ -8,6 +8,7 @@ public function aroundCatchException($subject, $callable, $bootstrap, $exception { $callable($bootstrap, $exception); - return \Rollbar\Rollbar::error($exception)->wasSuccessful(); + \Rollbar\Rollbar::error($exception); + return true; } }