-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: support for Spring WebFlux and Spring Boot 3.x #305
Comments
Hey @matsev, Thanks for reporting this request. I'll pick it up and get back to you with our findings. |
@matsev What's the minimum version of Java and Spring you want to work with? |
The project that I am currently working on is based on Java 17 and Spring Boot 3.1.1. Going forward, this project aims to upgrade with Java LTS versions when they become available in addition to upgrading Spring Boot releases when they become available. Spring Boot 3.x is based on Spring Framework 6.x and it's wiki page has a list of supported JDK versions:
The Spring Framework 6 release includes several breaking changes compared to the 5.x release. Copied from What's New in Version 6.0:
Additionally, Spring Boot 3 also has upgraded many other third party dependencies as mentioned in the release notes. For specific details about currently used versions, please refer to the spring-boot-dependencies pom file. |
@matsev Thanks for sharing. I'll bring this back to the devs. |
@matsev, I wanted to provide you with an update regarding your feature request. We've conducted an in-depth investigation into potential integration methods for reactive WebFlux applications. This area presents a notably intricate challenge compared to standard applications, where errors follow a more organized path. Reactive apps often traverse various execution threads, resulting in limited available information for effective handling. After careful consideration, we recommend utilizing the Our team extensively examined the popularity of this approach and assessed the level of effort required for comprehensive development. However, due to the relatively low demand for this solution and the inherent complexity of the development process, we regret that we won't be able to prioritize this work in our immediate roadmap. Nevertheless, I've added your request to our idea board to keep it on our radar for potential future considerations. Thank you for your understanding and continued support. |
@rollbar-bborsits thanks for your feedback. Based on your reply, I created a follow up ticket in which I suggest that you revisit the documentation of the |
Please add support for facilitating bootstrapping of Rollbar using Spring Webflux and Spring Boot 3.x.
According to the Rollbar changelog, support for Spring 6.x and Spring Boot 3.x was added as part of version 1.10.0. Additionally,
rollbar-reactive-streams
androllbar-reactive-streams-reactor
was released as part of version 1.9.0. However, it seems there is currently no support for the union Spring WebFlux and Spring Boot 3.x?One observation is that the
RollbarServletContextInitializer
provided by therollbar-spring-boot3-webmvc
library adds aRollbarRequestListener
to theServletContext
. This needs to be ported as there is no servlet context in the reactive world.Another observation is that Rollbar
rollbar-reactive-streams
has its ownAsyncHttpClient
interface with two different implementations. In contrast, the WebFlux WebClient can be backed by several different http clients. Ideally, Rollbar would pick anyWebClient
bean available in the application context or delegate to Spring for creation of a new one.The text was updated successfully, but these errors were encountered: