Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT + Trimming support #652

Open
beeradmoore opened this issue Mar 21, 2024 · 1 comment
Open

NativeAOT + Trimming support #652

beeradmoore opened this issue Mar 21, 2024 · 1 comment

Comments

@beeradmoore
Copy link

Is your feature request related to a problem? Please describe.
I am currently upgrading all of my AWS lambda functions to .NET 8. Some of the more commonly executed functions are getting the full NativeAOT + trimming support.

Rollbar.NET outputs some analysis warnings (will append soon once I have a clean sample to reproduce) of these features.

Is that something that Rollbar.NET has in mind of supporting?

From what I understand Newtonsoft.Json won't get that support itself so any json things would need to be replaced with System.Text.Json. I am not sure what else in here will cause headaches, I imagine there could be a lot of reflection used in here as well.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Updated codebase to support .NET 8 NativeAOT + trimming without producing warnings, without having required code accidentally trimmed away.

Describe alternatives you've considered
I have tried to use TrimmerRootAssembly in csproj file and rd.xml, but I can't seem to make the compiler happy.

My fallback solution would be to make (or see if others already exist) a very trimmed down Rollbar client that is specific to my lambda functions that can catch unhandled exceptions, and support logging using a REST API to Rollbar itself.

Additional context
N/A

@breyed
Copy link

breyed commented Dec 13, 2024

Rollbar also doesn't work in .NET MAUI when full trimming is enabled. It works if the entire Rollbar assembly is listed in the TrimmerRootDescriptor, but that causes the full assembly to be bundled without unused parts trimmed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants