Too strict cannot find name for type invalid or dynamic

[TwitchBronBron]

This should not be an error, because the variable is dynamic.

Discovered in the latest commits in v1 on Dec 23, 2024

[markwpearce]

hmm... I can't reproduce this with a test.

This passes in current release-1.0.0 branch:

it.only('allows member access of union with invalid', () => {
    program.setFile('source/main.bs', `
        sub test(channels)
            channel = invalid
            for each channel in channels
                if channel.id = 123
                    print "ok"
                end if
            end for
        end sub
    `);

    program.validate();
    expectZeroDiagnostics(program);
});

[TwitchBronBron]

Here's a test that fails with the issue. Mine was failing for object, but I added another union for roAssociativeArray to ensure that pattern works as well:

it.only('allows member access of union with invalid', () => {
    program.setFile('source/main.bs', `
        sub test()
            channel = invalid
            if true
                channel = {
                    height: 123
                }
            end if
            if true
                channel = createChannel({
                    height: 123
                })
            end if

            height = 0
            if channel <> invalid then
                height += channel.height
            end if
        end sub

        function createChannel(config) as object
            return config
        end function
    `);

    program.validate();
    expectZeroDiagnostics(program);
});