Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docusaurus 3.0 #313

Closed
mt89vein opened this issue Nov 1, 2023 · 9 comments · Fixed by #315
Closed

Support for Docusaurus 3.0 #313

mt89vein opened this issue Nov 1, 2023 · 9 comments · Fixed by #315
Labels
dependencies Pull requests that update a dependency file help wanted PRs are encouraged and will be accepted

Comments

@mt89vein
Copy link

mt89vein commented Nov 1, 2023

Docusaurus yesterday released 3.0 which includes support for react 18. I tried to upgrade, but I see that I get peer dependency warnings for this plugin.

Do you plan to release an update which will support docusuarus 3?

@zerosoul
Copy link

zerosoul commented Nov 2, 2023

me too

@rohit-gohri rohit-gohri added dependencies Pull requests that update a dependency file help wanted PRs are encouraged and will be accepted labels Nov 2, 2023
@rohit-gohri
Copy link
Owner

Happy to accept any PRs that update the dependencies and peer dependencies. I personally will not be able to work on it for some time.

@zabomate
Copy link
Contributor

zabomate commented Nov 4, 2023

@rohit-gohri please take a look at #314

@rohit-gohri
Copy link
Owner

Can someone install this test version - v0.0.0-test-20231104142351 and confirm if everything works?

@zabomate
Copy link
Contributor

zabomate commented Nov 4, 2023

@rohit-gohri I have tested and it works fine for me with the test package.

@rohit-gohri
Copy link
Owner

Thanks @zabomate ! Released as v2.0.0

@jwitz
Copy link

jwitz commented Dec 5, 2023

@zabomate Did you test with specs in external URLs? When I upgraded to 2.0.0, our remote specs broke (local refs worked fine).

After upgrading, I receive the same errors as in #299

@rohit-gohri
Copy link
Owner

@jwitz I do have a test and it is deployed - https://redocusaurus.vercel.app/examples/using-remote-url/

@jwitz
Copy link

jwitz commented Dec 12, 2023

Thanks for the response @rohit-gohri When I plugged in the pet store spec into our site it worked, but when I used https://api.astronomer.io/spec/platform/v1beta1 it threw the error. It looks like something in our spec might not be formatted properly, I will investigate an open a docs PR if our issue might be encountered by other developers

EDIT: If anyone comes across this issue, I found that my remote API specs didn't load on a local environment, but worked fine when deployed to Netlify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted PRs are encouraged and will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants