Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better font for the theme #69

Open
pourmand1376 opened this issue Feb 10, 2023 · 3 comments
Open

Add better font for the theme #69

pourmand1376 opened this issue Feb 10, 2023 · 3 comments

Comments

@pourmand1376
Copy link
Collaborator

pourmand1376 commented Feb 10, 2023

This is what al-folio uses.

<link rel="stylesheet" type="text/css" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700%7CRoboto+Slab:100,300,400,500,700%7CMaterial+Icons">
@rohandebsarkar
Copy link
Owner

I actually have a strong opinion on this. I believe we should leave it to the website viewers to choose their own fonts rather than downloading a specific font every time someone views the website.

But if you feel this feature maybe necessary for many users then we can think of a way to provide the users to choose their own fonts.

And I would also like to keep the resource calls as minimum as possible for a new visitor. If I am not wrong presently we make two resource calls (one for the html and one for the css), except on pages with math typesetting (then katex dependencies are required, I will look into it later if we can include katex dependencies within html during build time so we do not have to depend on CDNs).

@rohandebsarkar
Copy link
Owner

This is what al-folio uses.

* https://fonts.googleapis.com/css?family=Roboto:300,400,500,700%7CRoboto+Slab:100,300,400,500,700%7CMaterial+Icons
<link rel="stylesheet" type="text/css" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700%7CRoboto+Slab:100,300,400,500,700%7CMaterial+Icons">

This was included as a part of material bootstrap. While writing code for alshedivat/al-folio#741, I felt it was quite unnecessary if users do not want to use material design. I included a config to disable material design which will not include the font in al-folio.

@pourmand1376
Copy link
Collaborator Author

pourmand1376 commented Feb 10, 2023

I agree with your point. I think we should give the user the ability to change the font if he/she wants.

Today, I wanted to change the font to something else and I put in an hour and still I couldn't do it.

I do not have any problems here if it is simple enough for anyone to do it for themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants