Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Pre-commit checks #55

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add more Pre-commit checks #55

wants to merge 15 commits into from

Conversation

pourmand1376
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for academic-folio ready!

Name Link
🔨 Latest commit db2ae87
🔍 Latest deploy log https://app.netlify.com/sites/academic-folio/deploys/63e63c8278b1e600088207cb
😎 Deploy Preview https://deploy-preview-55--academic-folio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pourmand1376
Copy link
Collaborator Author

pourmand1376 commented Jan 28, 2023

I added support for gohtml formatter.

Also, I said that all line-endings should be lf. The default option is mixed which says that we accept the most used file format. I think we should agree on something, either lf or clrf. Both looks fine to me.

There is also some problem with header.html which this pre-commit is complaining about. I tested the online version here and it is still complaining about something.

@rohandebsarkar
Copy link
Owner

There was a wrong syntax, that was the problem. Fixed it, though the code is changed quite a bit in #56.

Merged #53 , #56. Therefore should only be merged after they are merged.

@rohandebsarkar rohandebsarkar marked this pull request as draft January 28, 2023 20:07
@rohandebsarkar rohandebsarkar linked an issue Jan 28, 2023 that may be closed by this pull request
@pourmand1376
Copy link
Collaborator Author

Thanks for drafting this PR. Since we do not want to have any conflicts, I think it is better if we wait until merging all current PRs. Then, we can add another branch, then change .pre-commit-config and .prettierrc and header.html and All other files would be fixed automatically!

@rohandebsarkar
Copy link
Owner

can you add this hook https://github.com/Lucas-C/pre-commit-hooks-java. I think there will be a lot of errors at first, we will have to resolve them one by one.

@pourmand1376
Copy link
Collaborator Author

pourmand1376 commented Feb 6, 2023

I added the prehook that you wanted. Maybe we have to add more parameters to it but at now it is good.

@pourmand1376
Copy link
Collaborator Author

can you add this hook https://github.com/Lucas-C/pre-commit-hooks-java. I think there will be a lot of errors at first, we will have to resolve them one by one.

prettier-plugin-go-template does the same. It first checks for syntax and then make it beautiful.

This plugin has problems with pre-commit online hook since It doesn't support java. So, I removed it for now.

@pourmand1376 pourmand1376 marked this pull request as ready for review February 7, 2023 20:59
@pourmand1376 pourmand1376 marked this pull request as draft February 7, 2023 21:06
@pourmand1376 pourmand1376 marked this pull request as ready for review February 10, 2023 12:48
@pourmand1376
Copy link
Collaborator Author

pourmand1376 commented Feb 10, 2023

We have problem in header.html and I can not solve it. Could you take a look? @rohandebsarkar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find Appropriate formatter for html files
2 participants