Clang tidy rein0925 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H1rono
reviewed
Mar 31, 2024
src/schneider_model.cpp
Outdated
Comment on lines
212
to
213
| // Silence all checks for all lines between the BEGIN and END | ||
| // NOLINTBEGIN |
There was a problem hiding this comment.
こういうつもりでした...
あと、NOLINTBEGINの前に空白2つ入ってるのが気になる
// ↓にNOLINTBEGINを書く理由の説明がここに入る
// NOLINTBEGIN
Closed
|
ちなみに，件の switch (num) {
case 1:
this->led1 = !this->led1;
break;
case 2:
this->led2 = !this->led2;
break;
case 3:
this->led3 = !this->led3;
break;
default:
break;
} |
|
じゃそれでもっかいPR出してください |
|
ただこれをclang formatがそれを許してくれないんですが大丈夫ですかね？？ |
|
じゃあとりあえず放置か... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
特に問題なさそうなので
pio checkに引っかからないようにしました