Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joy_readの引数を消す #159

Closed
H1rono opened this issue Apr 25, 2024 · 0 comments · Fixed by #162
Closed

joy_readの引数を消す #159

H1rono opened this issue Apr 25, 2024 · 0 comments · Fixed by #162
Labels
enhancement New feature or request refactoring カイゼン

Comments

@H1rono
Copy link
Member

H1rono commented Apr 25, 2024

#56 より

src/schneider_model.cpp:102: [high:error] 2 adjacent parameters of 'joy_read' of convertible types are easily swapped by mistake  [bugprone-easily-swappable-parameters,-warnings-as-errors]

呼び出しもと↓

this->joy_read(this->adcIn1.read(), this->adcIn2.read(), 0.0);

なので、joy_read内でadcInN.readを呼んでしまえばいい

#151 と一緒に解決したい

@H1rono H1rono added enhancement New feature or request refactoring カイゼン labels Apr 25, 2024
@H1rono H1rono linked a pull request Apr 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring カイゼン
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant