Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_level #62

Merged
merged 21 commits into from
Nov 28, 2024
Merged

Add log_level #62

merged 21 commits into from
Nov 28, 2024

Conversation

23-yoshikawa
Copy link
Contributor

No description provided.

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_level周りはよくかけています
他のlaunchファイルにもお願いします 🙏 🙏

device/joystick/joystick/joystick.py Outdated Show resolved Hide resolved
device/joystick/launch/joystick_launch.py Outdated Show resolved Hide resolved
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かなり良さそう
一回ruff formatruff check --fixをお願いします

device/joystick/launch/joystick_launch.py Outdated Show resolved Hide resolved
ul/launch/double_camera.py Outdated Show resolved Hide resolved
@H1rono H1rono linked an issue Aug 17, 2024 that may be closed by this pull request
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Comment on lines 16 to 23
camera0 = IncludeLaunchDescription(
PythonLaunchDescriptionSource(
PathJoinSubstitution(
[FindPackageShare("camera_reader"), "launch", "camera_reader_launch.py"]
)
),
launch_arguments=[("index", "0")],
launch_arguments=[("index", "0"), ("log_level", log_level)],
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

やっぱりこれだけだと通りません
launch_configurationsを設定する必要があります、記述例↓

launch_configurations={"param_file": power_map_param_file},

他のIncludeLaunchDescriptionを使っているところもこれをやる必要があるんですが、GroupActionの引数に設定する必要があるので気をつけてください

@23-yoshikawa
Copy link
Contributor Author

遅くなってしまってすみません

@H1rono H1rono merged commit 74f2239 into main Nov 28, 2024
1 check passed
@H1rono H1rono deleted the launch branch November 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_level launch引数
2 participants