Don't use ejs.render when options.client is true #96
Comments
|
@megakoresh thanks for the feedback! If you wish to contribute a pull request is very welcome. Anyway I can fix it, but I can't guarantee when. |
megakoresh
added a commit
to megakoresh/gulp-ejs
that referenced
this issue
Jun 16, 2017
Clientside templates will be named same as source files without extension, optionally adding `settings.suffix` to the end. Set options.filename to `file.basename` for caching (speeds up gulp watch task when working). New settings: `settings.suffix` - when `options.client` is `true`, appends the string provided to the end of the generated clientside template. Should fix issue rogeriopvl#96
|
Done. |
|
Hello? Can you merge that thing or say why it can't be merged? I'd really rather avoid linking a fork as dependency for my project. |
|
@rogeriopvl fix pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tried to use this to compile clientside templates, but since it uses
ejs.render, it will throw an error on various undefined variables during compilation. I can't provide browser variables - the plugin should useejs.compileif it seesoptions.clientis set to true.The text was updated successfully, but these errors were encountered: