Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Plugin Versions to AssemblyVersion when not provided #340

Open
roflmuffin opened this issue Feb 24, 2024 · 0 comments
Open

Default Plugin Versions to AssemblyVersion when not provided #340

roflmuffin opened this issue Feb 24, 2024 · 0 comments
Labels
area-API-PluginSystem
Milestone
Future

Comments

@roflmuffin
Copy link
Owner

roflmuffin commented Feb 24, 2024 •
edited
Loading

ModuleVersion should not be a required plugin field, and can instead be provided as a virtual property with an overridable value. When loading the plugin from core, infer this value from assembly version information, and if still unavailable <unknown>.

Priority order:

  • ModuleVersion override
  • Assembly.GetName().Version
  • "<unknown>"
@github-actions github-actions bot added the untriaged New issue has not been triaged label Feb 24, 2024
@roflmuffin roflmuffin modified the milestone: Future Feb 24, 2024
@github-actions github-actions bot removed the untriaged New issue has not been triaged label Feb 24, 2024
@KillStr3aK KillStr3aK mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-API-PluginSystem
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@roflmuffin