Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkedVector rehaul #135

Open
KillStr3aK opened this issue Nov 25, 2023 · 3 comments
Open

NetworkedVector rehaul #135

KillStr3aK opened this issue Nov 25, 2023 · 3 comments
Labels
area-API-SchemaSystem Related to the Source 2 Schema System untriaged New issue has not been triaged

Comments

@KillStr3aK
Copy link
Contributor

As far as I know CUtlVectorEmbeddedNetworkVar<> (NetworkedVector<>) is not supposed to only work with CHandle<> instances, and they can be used/treated like CUtlVector<>

is this a typo? CUtlVector<CEntityHandle>

also there is no point in implementing IReadOnlyCollection<> as we should be able to add new elements to the vector.

@roflmuffin
Copy link
Owner

Yeah this requires a full on managed side write I imagine, I did just entity handles on C++ side since the implementation exists in hl2sdk but I think it requires knowledge of the size of the underlying type?

@KillStr3aK
Copy link
Contributor Author

When this will be worked on, lets not forget about #613

@KillStr3aK
Copy link
Contributor Author

KillStr3aK commented Oct 8, 2024

I believe if that pr is shipped with that MemAlloc class we could have an implementation for these ˙CUtl*˙ classes on the managed side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-API-SchemaSystem Related to the Source 2 Schema System untriaged New issue has not been triaged
Projects
None yet
Development

No branches or pull requests

2 participants