reduce default number of substeps to 10

roelof-groenewald · Dec 12, 2023 · dda5707 · dda5707
1 parent 0c163c4
commit dda5707
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/Docs/source/usage/parameters.rst b/Docs/source/usage/parameters.rst
@@ -2153,7 +2153,7 @@ Maxwell solver: kinetic-fluid hybrid
 * ``hybrid_pic_model.n_floor`` (`float`) optional (default ``1``)
     If ``algo.maxwell_solver`` is set to ``hybrid``, this sets the plasma density floor, in :math:`m^{-3}`, which is useful since the generalized Ohm's law used to calculate the E-field includes a :math:`1/n` term.
 
-* ``hybrid_pic_model.substeps`` (`int`) optional (default ``100``)
+* ``hybrid_pic_model.substeps`` (`int`) optional (default ``10``)
     If ``algo.maxwell_solver`` is set to ``hybrid``, this sets the number of sub-steps to take during the B-field update.
 
 .. note::

diff --git a/Source/FieldSolver/FiniteDifferenceSolver/HybridPICModel/HybridPICModel.H b/Source/FieldSolver/FiniteDifferenceSolver/HybridPICModel/HybridPICModel.H
@@ -125,7 +125,7 @@ public:
         amrex::Real dt, int lev, DtType dt_type,
         amrex::IntVect ng, std::optional<bool> nodal_sync);
 
-    void BfieldPush (
+    void FieldPush (
         amrex::Vector<std::array< std::unique_ptr<amrex::MultiFab>, 3>>& Bfield,
         amrex::Vector<std::array< std::unique_ptr<amrex::MultiFab>, 3>>& Efield,
         amrex::Vector<std::array< std::unique_ptr<amrex::MultiFab>, 3>> const& Jfield,
@@ -157,7 +157,7 @@ public:
 
     // Declare variables to hold hybrid-PIC model parameters
     /** Number of substeps to take when evolving B */
-    int m_substeps = 100;
+    int m_substeps = 10;
 
     /** Electron temperature in eV */
     amrex::Real m_elec_temp;

diff --git a/Source/FieldSolver/FiniteDifferenceSolver/HybridPICModel/HybridPICModel.cpp b/Source/FieldSolver/FiniteDifferenceSolver/HybridPICModel/HybridPICModel.cpp
@@ -585,7 +585,7 @@ void HybridPICModel::BfieldEvolveRK (
 
     // The Runge-Kutta scheme begins here.
     // Step 1:
-    BfieldPush(
+    FieldPush(
         Bfield, Efield, Jfield, rhofield, edge_lengths,
         0.5_rt*dt, dt_type, ng, nodal_sync
     );
@@ -601,7 +601,7 @@ void HybridPICModel::BfieldEvolveRK (
     }
 
     // Step 2:
-    BfieldPush(
+    FieldPush(
         Bfield, Efield, Jfield, rhofield, edge_lengths,
         0.5_rt*dt, dt_type, ng, nodal_sync
     );
@@ -621,7 +621,7 @@ void HybridPICModel::BfieldEvolveRK (
     }
 
     // Step 3:
-    BfieldPush(
+    FieldPush(
         Bfield, Efield, Jfield, rhofield, edge_lengths,
         dt, dt_type, ng, nodal_sync
     );
@@ -637,7 +637,7 @@ void HybridPICModel::BfieldEvolveRK (
     }
 
     // Step 4:
-    BfieldPush(
+    FieldPush(
         Bfield, Efield, Jfield, rhofield, edge_lengths,
         0.5_rt*dt, dt_type, ng, nodal_sync
     );
@@ -667,7 +667,7 @@ void HybridPICModel::BfieldEvolveRK (
     }
 }
 
-void HybridPICModel::BfieldPush (
+void HybridPICModel::FieldPush (
         amrex::Vector<std::array< std::unique_ptr<amrex::MultiFab>, 3>>& Bfield,
         amrex::Vector<std::array< std::unique_ptr<amrex::MultiFab>, 3>>& Efield,
         amrex::Vector<std::array< std::unique_ptr<amrex::MultiFab>, 3>> const& Jfield,