Time for a new Gem?

[coofercat]

Is it time for a new gem build?

I ask because I just spent a few hours trying to figure out how to make a manifest that does a 'split' on a parameter. To try to make my life easier, I used the 1.0.1 gem to unit test it, but it seems that gem doesn't understand the 'split' function (having looked at the source, it seems the latest github version does). So I'd like to update the gem on our systems so that we can put these tests back in (seeing as Puppet itself is quite happy with my module, it seems helpful to be able to test it).

Anyone got any opinions/thoughts? Any idea when we can expect a new gem?

[jbussdieker]

👍

[mcanevet]

👍

[Henning-B]

👍

[vainikkaj]

👍

[nanorepublica]

👍

[tuxmea]

👍

[philipwigg]

+1

[hurrycaine]

pretty please

[raphink]

It would be great to get a new release, please.

[witjoh]

+5

[rnelson0]

@rodjek a v1.0.2 or v2.0.0 or whatever gem would be great. 1.0.1 was released a year ago.

Related issues: #227, #184, #174, #182, #177, which is not an exhaustive list.

[rnelson0]

@jeffmccune ping, looks like you might have the ability to do this as well.

[jeffmccune]

@rnelson0 Happy to publish a new release. I'd like to stick with semantic versioning, do we have a sense if the current master branch is backwards compatible with the current 1.0.1 release? If so, I'll cut 1.1.0, if not we'll need to cut 2.0.0 and convey the breaking changes in the release notes.

[rnelson0]

@jeffmccune I wouldn't know if any of the last 12 months of PRs breaks backwards compatability. It doesn't seem like it from the descriptions, but I am fairly new to rspec-puppet. I just know I've run into a few issues where I see a fix but it's not available unless I bundle the gem myself.

[tuxmea]

@jeffmccune I tried to review all commits since January. I haven't found commits which would break compatibility (which does not mean that my review is complete). Version 1.1.0 would be fine from my point of view.

[raphink]

Same here. I'd be happy with 1.1.0, ideally with #222 merged before the release, too ;-)

[jeffmccune]

@tuxmea @raphink Thank you for your time checking backwards compatibility, it's greatly appreciated and helps me a lot.

I'll review #222, hopefully merge it, and publish 1.1.0 today.

[jhoblitt]

I recently ported all of my forge modules to 6ac9799 so that I could add the future parser to the travis matrix. There were several small bits of breakage and most (all?) of my modules required forward porting work.

1. Some tests still had include_class, which I believe was long deprecated anyways.
2. I ended up pinning the version of rspec-core as gem 'rspec-core', '~> 2.0' to silence rspec 3 warnings. It would be nice if a new release set this requirement it it's gemspec.
3. It looks like libdir handling changes broke rspec-puppet-augeas "Could not set 'directory' on ensure: Permission denied" errors with rspec-puppet > 1.0.1 + puppet 3.7.3 future parser domcleal/rspec-puppet-augeas#15
4. All instances of verify_contents(subject, ...) broke as subject has been removed and replaced with catalogue. #subject method no longer exists #235
5. The construct I had been using to check for exceptions in negative tests broke. expect { should }.to raise_error(...) had to be replaced with should raise_error(...)

The last 2-3 are definitely breaking changes from 1.0.0 and I believe this warrants a major version bump. Otherwise, I expect 'rspec-puppet', '~> 1.0' will still break a number of module's tests.

[rnelson0]

Re pinning to rspec-core, it would be helpful to update https://tickets.puppetlabs.com/browse/PUP-3594 with the course of action.

[jeffmccune]

@jhoblitt Thanks for the information, I'll release master as 2.0.0 as a result.

[jeffmccune]

Looks like I don't have permission to publish the release to rubygems.org.

@rodjek Would you mind publishing 2.0.0 to rubygems org (master is currently the same as the v2.0.0 tag), or giving me access on https://rubygems.org/ to publish new releases?

$ bundle exec rake release
rspec-puppet 2.0.0 built to pkg/rspec-puppet-2.0.0.gem.
Tagged v2.0.0.
Pushed git commits and tags.
rake aborted!
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem.

Tasks: TOP => release
(See full trace by running task with --trace)

-Jeff

[jlambert121]

@jeffmccune would you be able to create a git tag for this release while we wait for @rodjek to help with getting the gem uploaded?

Edit - sorry, I just now went and looked again to make sure I checked tags and not branches - I was not, there is a tag already present.

[jeffmccune]

There should be the v2.0.0 tag in the Git repository.

[rnelson0]

@jeffmccune @rodjek Can rspec-puppet 2.0.0 be published to rubygems soon? #244 was filed recently, another dupe of this issue. Thanks.

[jeffmccune]

I tried, but I get You do not have permission to push to this gem.
@rodjek, could you give me access or push the release?

[rnelson0]

@jeffmccune @rodjek Bump.

[domcleal]

It appears 2.0.0 is now live: https://rubygems.org/gems/rspec-puppet/versions/2.0.0

[raphink]

🎉