Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Switch to mjml to handle email templates #1515

Closed
7 of 10 tasks
arsforza opened this issue Jul 18, 2024 · 3 comments · Fixed by #1527
Closed
7 of 10 tasks

[Task] Switch to mjml to handle email templates #1515

arsforza opened this issue Jul 18, 2024 · 3 comments · Fixed by #1527
Assignees

Comments

@arsforza
Copy link
Contributor

arsforza commented Jul 18, 2024

Who requested this feature?

@gulfaraz

User Story

As a developer
I want to use mjml to create email templates
So that emails are easier to create and style

What needs to be done

  • Install mjml
  • Migrate to object structure
  • Test for multiple disasters

After first review with @gulfaraz

  • Fix width on mobile
  • Set Arial as font
  • Add margin between action button and description on mobile
  • Fix "from nows from now" typo
  • Use correct button labels
  • Add Mailchimp footer
  • Fix event trigger issued text's size and spacing
  • Use date-fns instead of moment
  • (optional) Fix rounded buttons on Outlook (Windows)
  • Make single-logo countries logos smaller (by limiting height and adjusting width to that?)
@arsforza arsforza changed the title [FEATURE] Switch to mjml to handle email templates [Task] Switch to mjml to handle email templates Jul 18, 2024
@arsforza arsforza self-assigned this Jul 25, 2024
@jannisvisser
Copy link
Contributor

@arsforza @gulfaraz

  • I have merged the fix.email-logos branch into this one as discussed yesterday.
  • I noticed that the single logo countries have a huge logo, but that was already the case before, so decided to not let it block the email logo item, but maybe good to fix in this item still? (made a task above for it)
    Image

@gulfaraz
Copy link
Member

I noticed that the single logo countries have a huge logo, but that was already the case before, so decided to not let it block the email logo item, but maybe good to fix in this item still? (made a task above for it)

You should use height: 50px in the CSS or image height="50" in the IMG tag to set the height of the logo.

@gulfaraz
Copy link
Member

The can be closed after merging PRs #1527 and #1594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants