From 0e11b6f8952e1d80d0bf52f4d3cddc078134b7cf Mon Sep 17 00:00:00 2001 From: piotrk39 Date: Mon, 16 Dec 2024 15:42:09 +0100 Subject: [PATCH] Update description, title, comments and const names --- .../TriggerStateShouldHaveWarningEvents.spec.ts | 13 +++++-------- .../DisasterType/SwitchBetweenDisasterType.spec.ts | 3 ++- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/tests/e2e/tests/ChatSection/TriggerStateShouldHaveWarningEvents.spec.ts b/tests/e2e/tests/ChatSection/TriggerStateShouldHaveWarningEvents.spec.ts index 728f35490..91d9d8583 100644 --- a/tests/e2e/tests/ChatSection/TriggerStateShouldHaveWarningEvents.spec.ts +++ b/tests/e2e/tests/ChatSection/TriggerStateShouldHaveWarningEvents.spec.ts @@ -33,10 +33,7 @@ test.beforeEach(async ({ page }) => { }); test( - qase( - 43, - '[Trigger] Event list should show at least 1 trigger, medium or low warning event', - ), + qase(43, '[Trigger] Amount of events should equal the aggregate number'), async ({ page }) => { const aggregates = new AggregatesComponent(page); const dashboard = new DashboardPage(page); @@ -53,13 +50,13 @@ test( firstName: TriggerDataSet.firstName, lastName: TriggerDataSet.lastName, }); - await chat.allChatButtonsArePresent(); + await chat.allDefaultButtonsArePresent(); // get the number of warning events and aggregated events - const warningCount = await chat.chatPredictionButtonsAreActive(); - const aggregatesNumber = await aggregates.getNumberOfPredictedEvents(); + const chatEventCount = await chat.predictionButtonsAreActive(); + const aggregatesEventCount = await aggregates.getNumberOfPredictedEvents(); // check if the number of warning events is equal to the number of aggregated events - expect(warningCount).toEqual(aggregatesNumber); + expect(chatEventCount).toEqual(aggregatesEventCount); }, ); diff --git a/tests/e2e/tests/DisasterType/SwitchBetweenDisasterType.spec.ts b/tests/e2e/tests/DisasterType/SwitchBetweenDisasterType.spec.ts index 029893379..4d07b11c0 100644 --- a/tests/e2e/tests/DisasterType/SwitchBetweenDisasterType.spec.ts +++ b/tests/e2e/tests/DisasterType/SwitchBetweenDisasterType.spec.ts @@ -32,7 +32,8 @@ test.beforeEach(async ({ page }) => { NoTriggerDataSet.UserPassword, ); }); - +// Test is skipped because it was flaky and more invastigation is needed to fix it +// Logged in PBI: https://dev.azure.com/redcrossnl/IBF/_workitems/edit/32127/ test.skip( qase(10, 'All Disaster Types can be selected in no-trigger mode'), async ({ page }) => {