Add socket.io.min.js.map file #39
Comments
|
See sited rockstor-core PR comment: rockstor/rockstor-core#2751 (comment) for context. |
|
The following Django upstream issue looks to be related: https://code.djangoproject.com/ticket/33353 |
|
An alternative approach here, given the upstream Django issue sited, is to edit our existing socket.io.min.js to remove its upstream provided:
Adding the associated map file does add quite the weight here (187 K) but it keep us away from custom edits of upstream libraries: which is far less ideal than just adding weight. Plus we have the following: and the related rockstor-core issue of: rockstor/rockstor-core#2735 And our ultimate removal of socket.io use entirely via: Django Server Sent Events to provide live data requirements |
Adds back socket.io.min.js.map file from: https://unpkg.com/[email protected]/dist/socket.io.min.js.map to appease new sensitivities in Django 4.x in rockstor-core re collectstatic. Upstream reference: https://code.djangoproject.com/ticket/33353
|
Closing as: |
During test rpmbuild of rockstor-core testing branch PR: Update Django to latest 4.2 LTS ..." a new sensitivity regarding this file surfaced. Previous rpmbuilds for testing channel rockstor-core did not show this sensitivity.
It is proposed that we add this file to our testing branch in this repo to circumvent this new sensitivity and return to an rpmbuildable state.
Follow-up, in part, and map file matched to the changes made within testing branch in this repo in PR:
Update socket.io client lib #36 #37
Where
was introduced, and the old version of the map file removed.
Proposed new/matching map file:
Our existing (updated in #37) socket.io.min.js file does contain the following flag:
Which is thought to be triggering our newer Django collectstatic to flag the absence of this file, which is not normally required, and fail our rpmbuild process via the collectstatic step executed within the %check scriptlet.
The text was updated successfully, but these errors were encountered: