Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy files #2891

Open
phillxnet opened this issue Aug 20, 2024 · 1 comment
Open

Remove legacy files #2891

phillxnet opened this issue Aug 20, 2024 · 1 comment
Labels
UI-enhancement Enhancement, renovation, update within Web-UI.

Comments

@phillxnet
Copy link
Member

By way of preperation for our next Stable rpm release, it is proposed that we do a little house-keeping regarding some old legacy files, such as those dating back to pre rockstor-jslibs times. An example in this case would be the long defunct Django admin override files found in:

  • src/rockstor/templates/admin

Removing their interference with now way newer .venv files from our current Django:

  • .venv/lib/python3.11/site-packages/django/contrib/admin
@phillxnet
Copy link
Member Author

We also have some related clean-up regarding the movement of some CSS files, in rockstor-core, that are associated with JS counterparts in rockstor-jslibs; where we already have JS/CSS sets associated with projects such as:

E.g.:

bootstrap-*

./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-editable.css:* Copyright (c) 2013 Vitaliy Potapov; Licensed MIT */
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-editable.css: * Copyright 2012 Stefan Petre
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-switch.min.css: * Copyright 2012-2013 Mattia Larentis
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-timepicker.css: * Copyright 2013 Joris de Wit
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap.min.css: * Copyright 2011-2015 Twitter, Inc.
./src/rockstor/storageadmin/static/storageadmin/css/datepicker.css: * Copyright 2012 Stefan Petre

i.e. we have bootstrap associated JS files in rockstor-jslibs repo, but their associated bootstrap CSS files are in rockstor-core! Ergo remove from rockstor-core said CSS files and re-partner them with their associated JS files in rockstor-jslibs.

Font-awesome

Similarly, re re-location candidate, we have, in rockstor-core, font-awesome-4.7.0:

./src/rockstor/storageadmin/static/storageadmin/css/font-awesome-4.7.0/css
./src/rockstor/storageadmin/static/storageadmin/css/font-awesome-4.7.0/fonts

See also: "Post Poetry Milestone: Font Awesome upgrade consideration" #2537

Which would, in turn, have to move to rockstor-jslibs post the proposed removal, from rockstor-core, re-location to rockstor-jslibs.

@phillxnet phillxnet added the UI-enhancement Enhancement, renovation, update within Web-UI. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI-enhancement Enhancement, renovation, update within Web-UI.
Projects
None yet
Development

No branches or pull requests

1 participant