Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generics to query responses #73

Open
raheelrjunaid opened this issue Oct 15, 2023 · 1 comment
Open

Add generics to query responses #73

raheelrjunaid opened this issue Oct 15, 2023 · 1 comment

Comments

@raheelrjunaid
Copy link

I appears a wrapper around the QueriesApi is required to achieve result typing on queries (as denoted in the examples.ts). I propose adding typing to the rocksetClient.queries.query definition in

/**
* Results from the query.
* @type {Array<any>}
* @memberof QueryResponse
*/
results?: Array<any>;

The same goes for pagination: (getQueryResults)

* List of documents returned by the query.
* @type {Array<any>}
* @memberof QueryPaginationResponse
*/
results?: Array<any>;

@raheelrjunaid
Copy link
Author

I can work on this, but I'm looking to understand any missing context before beginning development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant