Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuperVersion is a struct, not a class #294

Merged
merged 1 commit into from
Oct 19, 2023
Merged

SuperVersion is a struct, not a class #294

merged 1 commit into from
Oct 19, 2023

Conversation

igorcanadi
Copy link

Summary:

./db/snapshot_impl.h:55:1: error: class 'SuperVersion' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]

Test Plan:

Reviewers:

@igorcanadi
SuperVersion is a struct, not a class
ed8e97e 
Summary:
```
./db/snapshot_impl.h:55:1: error: class 'SuperVersion' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
```

Test Plan:

Reviewers:
@igorcanadi igorcanadi requested a review from estalgo October 19, 2023 09:54
@igorcanadi igorcanadi merged commit 68c758a into master Oct 19, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estalgo estalgo estalgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorcanadi @estalgo