Conditionally enqueue scripts and styles only if there is a contact form rendered #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
commented
Aug 9, 2023
| */ | ||
| add_action( | ||
| 'wp_enqueue_scripts', | ||
| static function () { | ||
| 'wp_default_scripts', |
There was a problem hiding this comment.
Note that the use of wp_default_scripts is needed due to block themes since they apply the_content filters before the wp_enqueue_scripts action runs. By using wp_default_scripts and wp_default_styles we can be assured that the scripts and styles are registered so that they can be enqueued when blocks are rendered.
felixarntz
approved these changes
Aug 10, 2023
|
|
||
| if ( wpcf7_load_css() ) { | ||
| wpcf7_enqueue_styles(); | ||
| } |
There was a problem hiding this comment.
Given that these styles only affect the response related markup that is only triggered by an AJAX submission, it should be fine to load the CSS later - i.e. no layout shifts 👍
westonruter
force-pushed
the
fix/unconditional-enqueues
branch
from
18600a2 to
9d8fee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves frontend performance (the LCP metric) of the plugin by eliminating stylesheets and scripts from being enqueued on the frontend if there are no contact forms present. When all integrations are enabled (Stripe and
reCAPTCHA) this reduces TTFB-LCP by almost half on vanilla WordPress homepages (running Twenty Twenty-Three) without contact forms.Update regarding reCAPTCHA: As pointed out by @PhilMakower in #1278 (comment), reCAPTCHA actually works best when it is included on every page, even those that don't use contact forms. So when the reCAPTCHA integration is enabled, its script will continue to be enqueued on all pages. Once this PR is merged, I'll open another one to implement async loading of the reCAPTCHA scripts (
add/async-recaptchabranch)Fixes #1278.