Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline tests for jitter & dynamic latency #765

Closed
4 tasks done
baranovmv opened this issue Jul 25, 2024 · 0 comments
Closed
4 tasks done

Pipeline tests for jitter & dynamic latency #765

baranovmv opened this issue Jul 25, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@baranovmv
Copy link
Member

baranovmv commented Jul 25, 2024

  1. smoke test: automatic latency works (e.g.: enable latency tuning, run receiver for a while, check that niq latency is close to target; increase jitter, check that after a while niq latency is close to new target; decrease jitter, check; repeat a few times)

    it would be also great to add same test, but with automatic latency disabled, and check that niq latency stays close to target no matter what is the jitter

  2. smoke test: start latency works (set start latency different from target and see how niq latency starts with start_latency and goes to target)

  3. smoke test: min/max latency works (bounding of target latency)

  4. smoke test: jitter metric calculation

    // Check how receiver computes jitter metric.
    IGNORE_TEST(receiver_source, metrics_jitter) {
    // TODO(gh-688): implement test
    }

@gavv gavv mentioned this issue Jul 25, 2024
21 tasks
@gavv gavv changed the title Test jitter metrics Pipeline tests for jitter & dynamic latency Jul 25, 2024
@gavv gavv added this to Roc Toolkit Jul 28, 2024
@github-project-automation github-project-automation bot moved this to Frontlog in Roc Toolkit Jul 28, 2024
@gavv gavv self-assigned this Aug 2, 2024
@gavv gavv removed the status in Roc Toolkit Aug 2, 2024
@gavv gavv moved this to In work in Roc Toolkit Aug 2, 2024
@gavv gavv added this to the next milestone Aug 6, 2024
@gavv gavv closed this as completed Aug 6, 2024
@github-project-automation github-project-automation bot moved this from In work to Done in Roc Toolkit Aug 6, 2024
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 6, 2024
…fix bugs

- Use STS instead of system clock for timeouts. This allows to write
  fast pipeline tests not tied to real time.

- Properly compare STS timestamps in LatencyEstimator. Old code was
  doing comparison without handling possible wrap in several places.

- Adaptive latency fix: if new target is below minimum, but current
  target is above minimum, set target to the minimum instead of
  keeping target unmodified.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 6, 2024
- adaptive_latency_increase
- adaptive_latency_decrease
- adaptive_latency_upper_bound
- adaptive_latency_lower_bound
- metrics_jitter
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
…fix bugs

- Use STS instead of system clock for timeouts. This allows to write
  fast pipeline tests not tied to real time.

- Properly compare STS timestamps in LatencyEstimator. Old code was
  doing comparison without handling possible wrap in several places.

- Adaptive latency fix: if new target is below minimum, but current
  target is above minimum, set target to the minimum instead of
  keeping target unmodified.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
- adaptive_latency_increase
- adaptive_latency_decrease
- adaptive_latency_upper_bound
- adaptive_latency_lower_bound
- metrics_jitter
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
…fix bugs

- Use STS instead of system clock for timeouts. This allows to write
  fast pipeline tests not tied to real time.

- Properly compare STS timestamps in LatencyEstimator. Old code was
  doing comparison without handling possible wrap in several places.

- Adaptive latency fix: if new target is below minimum, but current
  target is above minimum, set target to the minimum instead of
  keeping target unmodified.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
- adaptive_latency_increase
- adaptive_latency_decrease
- adaptive_latency_upper_bound
- adaptive_latency_lower_bound
- metrics_jitter
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
…fix bugs

- Use STS instead of system clock for timeouts. This allows to write
  fast pipeline tests not tied to real time.

- Properly compare STS timestamps in LatencyEstimator. Old code was
  doing comparison without handling possible wrap in several places.

- Adaptive latency fix: if new target is below minimum, but current
  target is above minimum, set target to the minimum instead of
  keeping target unmodified.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
- adaptive_latency_increase
- adaptive_latency_decrease
- adaptive_latency_upper_bound
- adaptive_latency_lower_bound
- metrics_jitter
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
…fix bugs

- Use STS instead of system clock for timeouts. This allows to write
  fast pipeline tests not tied to real time.

- Properly compare STS timestamps in LatencyEstimator. Old code was
  doing comparison without handling possible wrap in several places.

- Adaptive latency fix: if new target is below minimum, but current
  target is above minimum, set target to the minimum instead of
  keeping target unmodified.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
- adaptive_latency_increase
- adaptive_latency_decrease
- adaptive_latency_upper_bound
- adaptive_latency_lower_bound
- metrics_jitter
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
…fix bugs

- Use STS instead of system clock for timeouts. This allows to write
  fast pipeline tests not tied to real time.

- Properly compare STS timestamps in LatencyEstimator. Old code was
  doing comparison without handling possible wrap in several places.

- Adaptive latency fix: if new target is below minimum, but current
  target is above minimum, set target to the minimum instead of
  keeping target unmodified.
gavv added a commit to gavv/roc-toolkit that referenced this issue Aug 7, 2024
- adaptive_latency_increase
- adaptive_latency_decrease
- adaptive_latency_upper_bound
- adaptive_latency_lower_bound
- metrics_jitter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants