Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement moving percentile algorithm #751

Closed
gavv opened this issue Jul 12, 2024 · 3 comments
Closed

Implement moving percentile algorithm #751

gavv opened this issue Jul 12, 2024 · 3 comments
Assignees
@novertia
Labels
algorithms Algorithms and data structures enhancement help wanted An important and awaited task but we have no human resources for it yet
Milestone
next

Comments

@gavv
Copy link
Member

gavv commented Jul 12, 2024 •
edited
Loading

Add a class that implements moving percentile algorithm based on these excellent articles:

(Also feel free to suggest a better approach if you know one).

The new class can be named MovQuantile or MovPercentile. Interface should be similar to core::MovStats class, which implements moving minimum, maximum, and variance.

We also need unit tests, you can find example here.

This task is needed for #712.
@gavv gavv added enhancement help wanted An important and awaited task but we have no human resources for it yet algorithms Algorithms and data structures labels Jul 12, 2024
@gavv gavv added this to Roc Toolkit Jul 12, 2024
@github-project-automation github-project-automation bot moved this to Frontlog in Roc Toolkit Jul 12, 2024
@gavv gavv moved this from Frontlog to Help wanted in Roc Toolkit Jul 12, 2024
@novertia
Copy link

Hi can I work on this issue

@gavv
Copy link
Member Author

gavv commented Jul 13, 2024

Sure, thanks!

novertia added a commit to novertia/roc-toolkit that referenced this issue Jul 15, 2024
@novertia
roc-streaminggh-751: feature checkpoint, rolling minimum
0edbfdb
novertia added a commit to novertia/roc-toolkit that referenced this issue Jul 15, 2024
@novertia
roc-streaminggh-751: rolling minimum bug fix, percentile add
5c1283e
novertia added a commit to novertia/roc-toolkit that referenced this issue Jul 17, 2024
@novertia
roc-streaminggh-751: Implemented moving quantile using partition heap
2bc56a1
novertia added a commit to novertia/roc-toolkit that referenced this issue Jul 17, 2024
@novertia
roc-streaminggh-751 ran formatter
96e6f4a
@novertia novertia mentioned this issue Jul 17, 2024
Merged
novertia added a commit to novertia/roc-toolkit that referenced this issue Jul 19, 2024
@novertia
roc-streaminggh-751 documented code
0342c08
@gavv gavv added this to the next milestone Aug 1, 2024
gavv pushed a commit to novertia/roc-toolkit that referenced this issue Aug 1, 2024
@novertia @gavv
roc-streaminggh-751: Mov quantile
2d7bc90
gavv pushed a commit that referenced this issue Aug 1, 2024
@novertia @gavv
gh-751: Mov quantile
6f18841
@gavv
Copy link
Member Author

gavv commented Aug 1, 2024

Merged

@gavv gavv closed this as completed Aug 1, 2024
@github-project-automation github-project-automation bot moved this from Help wanted to Done in Roc Toolkit Aug 1, 2024
jeshwanthreddy13 pushed a commit to jeshwanthreddy13/roc-toolkit that referenced this issue Aug 6, 2024
@novertia @jeshwanthreddy13
roc-streaminggh-751: Mov quantile
76af77e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novertia novertia

Labels
algorithms Algorithms and data structures enhancement help wanted An important and awaited task but we have no human resources for it yet
Projects
Roc Toolkit
Status: Done
Milestone
next
Development

No branches or pull requests
2 participants
@gavv @novertia