Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom selector for prometheus service auto discovery #303

Open
mrueg opened this issue Jun 27, 2024 · 3 comments
Open

Custom selector for prometheus service auto discovery #303

mrueg opened this issue Jun 27, 2024 · 3 comments

Comments

@mrueg
Copy link
Contributor

mrueg commented Jun 27, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The auto discovery of prometheus uses hardcoded labels which just gets longer and longer.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Allow the user to specify selectors that point to the right service.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Forking the repo
Are you interested in contributing a PR for this?
Yes/no. If yes, we will provide guidance what parts of the code to modify and help you.
Not sure yet.
Additional context
Add any other context or screenshots about the feature request here.

@aantn
Copy link
Contributor

aantn commented Jun 27, 2024

Hi @mrueg, we are open to a PR for this! Absolutely.

@aantn
Copy link
Contributor

aantn commented Jun 27, 2024

It would be best to base the PR on the prometheus-workload-loader branch which has some major changes that will be merged soon.

@aantn
Copy link
Contributor

aantn commented Jun 27, 2024

One more thing: note that as a workaround you may be able to use --prometheus-url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants