Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve whether bug leads to a crash or incorrect behavior at runtime #446

Open
ChrisTimperley opened this issue Sep 9, 2021 · 3 comments
Assignees

Comments

@ChrisTimperley
Copy link
Member

ChrisTimperley commented Sep 9, 2021

Relevant bug: geometry2/1b5fa94/1b5fa94.bug

@gavanderhoorn we're unsure whether this leads to either: (a) a crash at run-time, or (b) using a meaningless/corrupted transform. If the former, then we should go with LOSS-OF-FUNCTIONALITY. If the latter, we should go with BEHAVING-INCORRECTLY.

Originally posted by @ChrisTimperley in #430 (comment)

@ChrisTimperley ChrisTimperley changed the title @gavanderhoorn we're unsure whether this leads to either: (a) a crash at run-time, or (b) using a meaningless/corrupted transform. If the former, then we should go with LOSS-OF-FUNCTIONALITY. If the latter, we should go with BEHAVING-INCORRECTLY. Resolve whether bug leads to a crash or incorrect behavior at runtime Sep 9, 2021
@ChrisTimperley
Copy link
Member Author

@gavanderhoorn @ipa-hsd I've moved this issue to here.

@gavanderhoorn
Copy link
Member

If I understand 1b5fa94 correctly, it would lead to a memory leak.

So (at a high-level): if any Python node which uses TF2 runs for a sufficient amount of time, it will run out of memory and crash.

From the linked PR:

I have found a memory leak in tf2_py.cpp
[..]
Whit this fix the memory leak is fixed.
We have experience this memory leak when having robots working during days.

@gavanderhoorn
Copy link
Member

Btw: it looks like ros/geometry2#258 is the issue which reported this (although it was reported by a different user).

Perhaps we should update the .bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants