Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not a bug: dab1b8a? #427

Open
gavanderhoorn opened this issue Jun 30, 2021 · 2 comments
Open

not a bug: dab1b8a? #427

gavanderhoorn opened this issue Jun 30, 2021 · 2 comments
Labels

Comments

@gavanderhoorn
Copy link
Member

Similar to #426. This bug description (dab1b8a) references another commit in the same PR as in #426.

Same question.

@ChrisTimperley
Copy link
Member

Thanks for pointing this out. This is a more general issue: Should we consider bug fixes that occur on PR branches within our dataset? The only repo that should be affected by this issue is MAVROS, since that's the only repo where we looked at commits rather than just PR/issues. Let's figure out how many bugs within our dataset occur on PR branches, and then we can discuss and make a decision on the issue at our next meeting.

@gavanderhoorn
Copy link
Member Author

gavanderhoorn commented Jul 7, 2021

There's a really on-topic Github help article about this: Searching issues and pull requests.

Example: https://api.github.com/search/issues?q=<INSERT_HASH_HERE>.

That should result in (a list of) https://api.github.com/repos/<ORG>/<REPO>/issues/<PR_ID>.


Edit: for bug dab1b8a: https://api.github.com/search/issues?q=dab1b8a16d6194056cb7e76215ecf299d1a90f08.

Which returns mavlink/mavros#230, which is indeed the PR that commit is part of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants