Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs that haven't been fixed should have a "null" fix section #425

Open
ChrisTimperley opened this issue Jun 17, 2021 · 3 comments
Open
Labels
bug Something isn't working bug-descriptions

Comments

@ChrisTimperley
Copy link
Member

An example of a bug that breaks this rule:

https://github.com/robust-rosin/robust/blob/master/care-o-bot/0000000/0000000.bug

@ChrisTimperley ChrisTimperley added bug Something isn't working bug-descriptions labels Jun 17, 2021
@gavanderhoorn
Copy link
Member

I guess in that example the issue was fixed, but it didn't require a code change, hence no commit to point to?

@ChrisTimperley
Copy link
Member Author

Interesting. Should we really consider that example to be a bug in that case? (Either way, it seems like a null or other special value should be used for the fix section.)

@hsd-dev
Copy link
Contributor

hsd-dev commented Jun 23, 2021

Maybe this bug got left out. Others have been set to null in 85a8ba1. Will take a look again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-descriptions
Projects
None yet
Development

No branches or pull requests

3 participants