Pyangbind generates redundant python classes for each included submodule

[matej-staron]

Hi,

I came across this weird situation. When a single module including other submodules is built, pyangbind seems to generate set of classes with identical content (compared to the classes built from the main module) for each of included submodules.
This results in considerable overhead in generated .py files. The redundant classes seem to behave in the same manner as the 'original' class, thus having no actual use.

Let's say we have these two files (main-module.yang, submodule-one.yang):

module main-module {
    prefix "main";
    namespace "http://example.com/foo";
    include submodule-one;

    leaf main-mod-item {
        type int32;
    }
}

submodule submodule-one {
    belongs-to main-module  { prefix "main"; }

    container submod-container {
        leaf submod-item {
            type string;
        }
    }
}

After using pyangbind to build main-module.yang, generated python class contains 'doubled' code, allowing identical operations on these classes:

>>> from pybind_output import main_module
>>> from pybind_output import submodule_one
>>> mm = main_module()
>>> sm = submodule_one()
>>> mm.get()
{'main-mod-item': 0L, 'submod-container': {'submod-item': u''}}
>>> sm.get()
{'main-mod-item': 0L, 'submod-container': {'submod-item': u''}}

I am not completely sure whether this is an actual feature or a bug.
Could you please look into this?

[robshakir]

Thanks for the report here. This does look to be a bug.

I have a fix for this in a development branch where I am working through some other issues, I'll merge it ASAP.

If fixing this is more urgent, please let me know and I can cherry-pick this back into master quicker.

r.

[matej-staron]

Thanks for feedback.
Fixing is not urgent.

[password636]

@robshakir Is the fix not merged yet? Or could you let me know which branch has the fix?