Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing OS targets vivid etc #116

Open
tfoote opened this issue Nov 18, 2015 · 3 comments
Open

missing OS targets vivid etc #116

tfoote opened this issue Nov 18, 2015 · 3 comments

Comments

@tfoote
Copy link

tfoote commented Nov 18, 2015

I'm running on vivid and there are lots of warnings due to vivid not being in this file. Such as the following:

[WARN] [WallTime: 1447805278.124815] Rapp Manager : 'rocon_apps/lion_chirp' is invalid [operating_system specification is invalid or not officially registered (see https://github.com/robotics-in-concert/rocon_tools/blob/indigo/rocon_uri/src/rocon_uri/rules/rules.yaml)[vivid]]

This file only seems that it can get out of date? Why reproduce the data here?

@stonier
Copy link
Member

stonier commented Dec 11, 2015

Short term, I've added the operating system to the rules.

Long term an agnostic rapp like chirp shouldn't care about the operating system underneath. I think this has been fixed in our recent branch, but I'll leave this open here till I confirm.

Yes, it can get out of date. If I recall, this was so validition at various levels could be tighter than just string matching any pair of strings at runtime (e.g. vivix would get caught as an error earlier in development rather than at runtime later when failing against an os with vivid). Tradeoff of course is it needs more maintenance. If I did this again, I'd be more inclined to avoid the maintenance, as I see you are.

What did you mean by reproduce? Is it getting produced elsewhere?

@tfoote
Copy link
Author

tfoote commented Dec 11, 2015

I meant reproduce the list of possible os's to validate against. You can probably pull it in from rospkg. https://github.com/ros-infrastructure/rospkg/blob/master/src/rospkg/os_detect.py

@stonier
Copy link
Member

stonier commented Dec 14, 2015

Ah, got it. Tasks for this issue:

  • rapps with no dependencies should be agnostic about a missing operating system match.
  • operating system list should at least be initialised from rospkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants