Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up gateway_hub implementation #222

Open
piyushk opened this issue Dec 4, 2013 · 2 comments
Open

Clean up gateway_hub implementation #222

piyushk opened this issue Dec 4, 2013 · 2 comments
Assignees
Milestone

Comments

@piyushk
Copy link
Collaborator

piyushk commented Dec 4, 2013

While introducing the hub sidekick and connection statistics, I've made a bit of a mess of the gateway_hub implementation.

@ghost ghost assigned piyushk Dec 4, 2013
@piyushk
Copy link
Collaborator Author

piyushk commented Dec 4, 2013

Need to work on this issue once #221 gets pulled in, as I wanted to split cleaning up in a separate pull request.

  • Learn how to make these lists
  • Move named_gateway functions to rocon_hub_client. All the named_gateway functions should uniformly use the gateway_name instead of key.
  • Check if parsing functions are really needed. If needed, move them to rocon_hub_client. Should probably look more closely at the pyredis code.
  • Modify all the connection statistics set and get functions to use pipelines. Save on number of individual requests.
  • Get hub sidekick to use rocon_hub_client instead of gateway_hub.

@piyushk
Copy link
Collaborator Author

piyushk commented Dec 9, 2013

Since this issue is non-essential, I will get back to it once the demo is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant