minor followup issues for service cache manager.

[jihoonl]

It is follow up issue of #257

• use rocon_python_utils.ros.get_ros_friendly_name() for places like

  rocon_concert/concert_service_manager/src/concert_service_manager/service_cache_manager.py

  Line 99 in 8928561

  self._concert_name = concert_name.strip().lower().replace(' ', '_')

• improve service_cache_manager._create_service_cache logic.

  rocon_concert/concert_service_manager/src/concert_service_manager/service_cache_manager.py

  Lines 163 to 182 in 8928561

  	def _create_service_cache(self):
  	"""
  	Create cache as loading service configuration from default value.
  	"""
  	# read resource file
  	loaded_profiles = {}
  	service_configurations = load_solution_configuration_from_default(rocon_python_utils.ros.find_resource_from_string(self._resource_name))
  	for service_configuration in service_configurations:
  	resource_name = check_extension_name(service_configuration['resource_name'], '.service')
  	overrides = service_configuration['overrides']
  	try:
  	loaded_profile = self._load_service_profile_from_default(resource_name, overrides)
  	self._save_service_profile(loaded_profile)
  	loaded_profiles[loaded_profile['name']] = copy.deepcopy(loaded_profile)
  	except rospkg.ResourceNotFound as e:
  	self.logwarn('Cannot load service configuration: [%s]' % resource_name)
  	continue
  	# save solution configuration
  	self._save_solution_configuration(loaded_profiles)

  • it is saving service profile while loading. service saving should be done with save solution configuration.
• os.path.isfile(interactions_yaml_file) or os.stat(interactions_yaml_file).st_size <= 0: are used to check file existence and whether the file is up-to-date.
  • We may want to move this into rocon_python_utils as method.
• rocon_python_utils.ros.paths -> rocon_python_utils.system.fileio
  • it is module to control file system.
• rename default_auto_enable_services to default_enable_services